fix(adb): remove false exclusivity from the push-file description (#2990)
push_adb_file claimed to be the only device-mutating ADB tool while install, uninstall, start-app, start-activity and stop-app are also device-mutating. Drop the exclusivity claim from the contract description and the push limitations, keeping the device-mutation fact. Fixes #2602. Co-authored-by: me <me@medz.org>
This commit is contained in:
1 parent
dd36b4a8a0
commit
9630c8ff46
2 files changed
+3
-5
No files matched your search
@@ -1707,9 +1707,7 @@ export class AdbProvider {
|
||||
},
|
||||
provider,
|
||||
{
|
||||
limitations: [
|
||||
"Push writes the caller's file to the device; this is the only device-mutating ADB tool",
|
||||
],
|
||||
limitations: ["Push writes the caller's file to the device"],
|
||||
},
|
||||
),
|
||||
);
|
||||
@@ -1731,7 +1729,7 @@ export class AdbProvider {
|
||||
{
|
||||
limitations: [
|
||||
"The device did not answer sha256sum, so the transfer is not device-side verified",
|
||||
"Push writes the caller's file to the device; this is the only device-mutating ADB tool",
|
||||
"Push writes the caller's file to the device",
|
||||
],
|
||||
},
|
||||
),
|
||||
|
||||
@@ -127,7 +127,7 @@ export const ADB_TOOL_CONTRACTS = [
|
||||
name: "push_adb_file",
|
||||
...toolContractMetadata("push_adb_file"),
|
||||
description:
|
||||
"Push one local file to an absolute device path. The only device-mutating ADB tool: existing device files are refused unless overwrite is explicitly requested, and the transfer is verified by comparing the local digest with the device's own sha256sum when the device provides one.",
|
||||
"Push one local file to an absolute device path. A device-mutating tool: existing device files are refused unless overwrite is explicitly requested, and the transfer is verified by comparing the local digest with the device's own sha256sum when the device provides one.",
|
||||
kind: "adb-provider",
|
||||
inputSchema: adbInputSchemas.push_adb_file,
|
||||
outputSchema: evidenceResultOf(adbResultSchemas.push_adb_file),
|
||||
|
||||
Reference in new issue
Block a user