scripte/nexarch
1
0 Fork 0
Code Issues 1 Pull Requests 6 Actions Packages Projects Releases Wiki Activity

test: fakeKEKProvider/fakeKEK-Dopplung in testutil-Paekete konsolidiert #370

Open
patrick wants to merge 1 commits from test/dedup-fakekek-testutil into main
pull from: test/dedup-fakekek-testutil
merge into: scripte:main
Conversation 0 Commits 1 Files Changed 28
+119 -195
patrick commented 2026-10-19 14:48:04 +02:00
Owner
Copy link
Copy source

Fable-Review P1: byteidentische Test-Doubles (fakeKEKProvider: 21 Dateien, fakeKEK: 7 Dateien) je Modul in internal/testutil konsolidiert. Nur Tests betroffen, kein Produktionscode. go build/vet/test sauber auf Testhost 131.

🤖 Generated with Claude Code

Fable-Review P1: byteidentische Test-Doubles (fakeKEKProvider: 21 Dateien, fakeKEK: 7 Dateien) je Modul in internal/testutil konsolidiert. Nur Tests betroffen, kein Produktionscode. go build/vet/test sauber auf Testhost 131. 🤖 Generated with [Claude Code](https://claude.com/claude-code)
patrick added 1 commit 2026-10-19 14:48:05 +02:00
test: fakeKEKProvider/fakeKEK-Dopplung in testutil-Pakete konsolidiert
CI / Web-Barrierefreiheitspruefung (axe, Tastatur, Reflow, Textabstaende) (push) Canceled after 0s
Details
CI / Web-Barrierefreiheitspruefung (axe, Tastatur, Reflow, Textabstaende) (pull_request) Canceled after 0s
Details
CI / Core-Modul (Build/Vet/Test) (push) Canceled after 0s
Details
CI / DMS Security-Test-Gate (AC5, Merge-Gate) (push) Canceled after 0s
Details
CI / Connect Security-Test-Gate (QA-01 AC4, Merge-Gate) (push) Canceled after 0s
Details
CI / DMS Security-Test-Gate (AC5, Merge-Gate) (pull_request) Canceled after 0s
Details
CI / Connect Security-Test-Gate (QA-01 AC4, Merge-Gate) (pull_request) Canceled after 0s
Details
Archive-Pflichttest-Gate / pflichttest-gate (pull_request) Canceled after 0s
Details
Supply-Chain-Scan (Go) / govulncheck (push) Canceled after 0s
Details
Supply-Chain-Scan (Go) / govulncheck (pull_request) Canceled after 0s
Details
CI / DMS-Modul Supply-Chain-Scan (govulncheck) (push) Canceled after 0s
Details
CI / Web (dms-browser) (push) Canceled after 0s
Details
CI / Web (pdf-viewer) (push) Canceled after 0s
Details
CI / Web (shl) (push) Canceled after 0s
Details
CI / Core-Modul (Build/Vet/Test) (pull_request) Canceled after 0s
Details
CI / DMS-Modul Supply-Chain-Scan (govulncheck) (pull_request) Canceled after 0s
Details
CI / Web (dms-browser) (pull_request) Canceled after 0s
Details
CI / Web (pdf-viewer) (pull_request) Canceled after 0s
Details
CI / Web (shl) (pull_request) Canceled after 0s
Details
Connect-Schnittstellen-Vertragstests / contract-tests (push) Canceled after 0s
Details
Connect-Schnittstellen-Vertragstests / contract-tests (pull_request) Canceled after 0s
Details
Core-Schnittstellen-Vertragstests / contract-tests (pull_request) Canceled after 0s
Details
Supply-Chain-Scan (npm) / npm-audit (pull_request) Canceled after 0s
Details
Core-Pflichttest-Gate / pflichttest-gate (pull_request) Canceled after 0s
Details
RBAC-Rollenhierarchie-Pflichtgate / rbac-policy-invariant (pull_request) Canceled after 0s
Details
CI / DMS-Modul (Lint/Build/Test/Coverage/Artefakt) (push) Canceled after 0s
Details
CI / DMS-Modul (Lint/Build/Test/Coverage/Artefakt) (pull_request) Canceled after 0s
Details
35904c0a35 
Fable-Review auf Code-Dopplung (P1). Byteidentische Test-Doubles, die
unabhaengig in vielen *_test.go-Dateien dupliziert waren, je Modul in
ein neues internal/testutil-Paket gezogen (Go-Modulgrenzen verhindern
ein gemeinsames Paket ueber dms/archive/connect hinweg):

- dms/internal/testutil.FakeKEKProvider: 14 Dateien (thumbnail,
  versioningapi, documentapi, pdfsign, docmerge, pdfconvert, export,
  watchfolder, downloadapi, malwarescan, uploadapi, versioning,
  migrationdocument, upload) + 2 weitere Nutzstellen ohne eigene
  Typdefinition (versioning/diff_test.go, uploadapi/int19_...).
  dms/internal/crypto/service_test.go NICHT angefasst -- eigene
  Call-Counting-Variante, keine echte Dopplung.
- archive/internal/testutil.FakeKEKProvider: backup + objectbackup
  (tenant-keyed Map-Variante, von der dms-Variante verschieden).
- connect/internal/testutil.FakeKEK: 7 Dateien (backupconnector,
  credential, contracttest, connectorsetupapi, webhooksub x2,
  m365connector). connect/internal/crypto/envelope_test.go NICHT
  angefasst -- einziges Vorkommen, keine Dopplung.

fakeUsageReporter/fakeVerifier bewusst NICHT konsolidiert: bei Pruefung
stellten sich die meisten Vorkommen als inhaltlich verschiedene
Varianten heraus (unterschiedliche Felder/Fehlerpfade), keine echte
Kopie. Die eine echte Dopplung (archive/workflow moduleadapter) liegt
ueber einer Modulgrenze, nicht ohne neue Shared-Library loesbar.

go build/vet/test (-p 1) sauber in allen betroffenen Paketen von dms,
archive, connect auf Testhost 131.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Some required checks failed
CI / Web-Barrierefreiheitspruefung (axe, Tastatur, Reflow, Textabstaende) (push) Canceled after 0s
Details
CI / Web-Barrierefreiheitspruefung (axe, Tastatur, Reflow, Textabstaende) (pull_request) Canceled after 0s
Details
CI / Core-Modul (Build/Vet/Test) (push) Canceled after 0s
Details
CI / DMS Security-Test-Gate (AC5, Merge-Gate) (push) Canceled after 0s
Details
CI / Connect Security-Test-Gate (QA-01 AC4, Merge-Gate) (push) Canceled after 0s
Details
CI / DMS Security-Test-Gate (AC5, Merge-Gate) (pull_request) Canceled after 0s
Details
CI / Connect Security-Test-Gate (QA-01 AC4, Merge-Gate) (pull_request) Canceled after 0s
Details
Archive-Pflichttest-Gate / pflichttest-gate (pull_request) Canceled after 0s
Details
Supply-Chain-Scan (Go) / govulncheck (push) Canceled after 0s
Details
Supply-Chain-Scan (Go) / govulncheck (pull_request) Canceled after 0s
Details
CI / DMS-Modul Supply-Chain-Scan (govulncheck) (push) Canceled after 0s
Details
CI / Web (dms-browser) (push) Canceled after 0s
Details
CI / Web (pdf-viewer) (push) Canceled after 0s
Details
CI / Web (shl) (push) Canceled after 0s
Details
CI / Core-Modul (Build/Vet/Test) (pull_request) Canceled after 0s
Details
CI / DMS-Modul Supply-Chain-Scan (govulncheck) (pull_request) Canceled after 0s
Details
CI / Web (dms-browser) (pull_request) Canceled after 0s
Details
CI / Web (pdf-viewer) (pull_request) Canceled after 0s
Details
CI / Web (shl) (pull_request) Canceled after 0s
Details
Connect-Schnittstellen-Vertragstests / contract-tests (push) Canceled after 0s
Details
Connect-Schnittstellen-Vertragstests / contract-tests (pull_request) Canceled after 0s
Details
Core-Schnittstellen-Vertragstests / contract-tests (pull_request) Canceled after 0s
Details
Supply-Chain-Scan (npm) / npm-audit (pull_request) Canceled after 0s
Details
Core-Pflichttest-Gate / pflichttest-gate (pull_request) Canceled after 0s
Details
RBAC-Rollenhierarchie-Pflichtgate / rbac-policy-invariant (pull_request) Canceled after 0s
Details
CI / DMS-Modul (Lint/Build/Test/Coverage/Artefakt) (push) Canceled after 0s
Details
CI / DMS-Modul (Lint/Build/Test/Coverage/Artefakt) (pull_request) Canceled after 0s
Details
This pull request has changes conflicting with the target branch.
  • connect/internal/backupconnector/backupconnector_test.go
  • connect/internal/connectorsetupapi/connectorsetupapi_test.go
  • connect/internal/contracttest/contracttest_test.go
  • connect/internal/credential/credential_test.go
  • connect/internal/m365connector/m365connector_test.go
  • dms/internal/docmerge/docmerge_test.go
  • dms/internal/documentapi/handler_test.go
  • dms/internal/downloadapi/handler_test.go
  • dms/internal/export/export_test.go
  • dms/internal/malwarescan/scan_test.go
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin test/dedup-fakekek-testutil:test/dedup-fakekek-testutil
git checkout test/dedup-fakekek-testutil
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
patrick
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: scripte/nexarch#370