scripte/timemaster
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

fix(time): break_minutes DB-Default ergänzen + Retention-Tests korrigiert

Browse Source 
Gleiches Muster wie hours_payouts.status (7166bbb): Model hatte nur
Python-default, kein server_default -> Migration 0044 zieht DB-Default
nach. Retention-Tests nutzten fehlenden Wert bei Raw-SQL-Insert und
fehlenden RLS-Bypass zwischen den Transaktionsgrenzen.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Gis16MnuwkYcivLrSxK1pD
This commit is contained in:
patrick
2026-08-27 09:06:59 +02:00
co-authored by Claude Sonnet 5
parent 5a9e432a80
commit cfa707d8f9
3 changed files with 42 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files
backend/tests/test_retention.py
+16 -7
View File
@@ -21,7 +21,9 @@ async def retention_headers(client: AsyncClient):
})
assert resp.status_code == 201, resp.text
data = resp.json()
return {"Authorization": f"Bearer {data['access_token']}"}, data["user"]["company_id"]
headers = {"Authorization": f"Bearer {data['access_token']}"}
me = await client.get("/api/v1/users/me", headers=headers)
return headers, me.json()["company_id"]
@pytest.mark.asyncio(loop_scope="session")
@@ -35,20 +37,23 @@ async def test_purge_deletes_old_time_entries_respects_retention(
old_date = date.today() - timedelta(days=11 * 365) # älter als Default 10 Jahre
recent_date = date.today() - timedelta(days=30)
await db_session.execute(text("SET LOCAL app.bypass_rls = 'on'"))
await db_session.execute(text(
"INSERT INTO time_entries (id, user_id, date, start_time, end_time, status, source) "
"VALUES (gen_random_uuid(), :uid, :d, '08:00', '16:00', 'approved', 'web')"
"INSERT INTO time_entries (id, user_id, date, start_time, end_time, break_minutes, status, source) "
"VALUES (gen_random_uuid(), :uid, :d, '08:00', '16:00', 0, 'approved', 'web')"
), {"uid": user_id, "d": old_date})
await db_session.execute(text(
"INSERT INTO time_entries (id, user_id, date, start_time, end_time, status, source) "
"VALUES (gen_random_uuid(), :uid, :d, '08:00', '16:00', 'approved', 'web')"
"INSERT INTO time_entries (id, user_id, date, start_time, end_time, break_minutes, status, source) "
"VALUES (gen_random_uuid(), :uid, :d, '08:00', '16:00', 0, 'approved', 'web')"
), {"uid": user_id, "d": recent_date})
await db_session.commit()
await db_session.execute(text("SET LOCAL app.bypass_rls = 'on'"))
result = await run_retention_purge(db_session, company_id=company_id)
await db_session.commit()
assert result["time_entries"] == 1
await db_session.execute(text("SET LOCAL app.bypass_rls = 'on'"))
remaining = await db_session.execute(text(
"SELECT date FROM time_entries WHERE user_id = :uid"
), {"uid": user_id})
@@ -70,12 +75,14 @@ async def test_purge_configurable_retention_years(
user_id = me.json()["id"]
three_years_ago = date.today() - timedelta(days=3 * 365)
await db_session.execute(text("SET LOCAL app.bypass_rls = 'on'"))
await db_session.execute(text(
"INSERT INTO time_entries (id, user_id, date, start_time, end_time, status, source) "
"VALUES (gen_random_uuid(), :uid, :d, '08:00', '16:00', 'approved', 'web')"
"INSERT INTO time_entries (id, user_id, date, start_time, end_time, break_minutes, status, source) "
"VALUES (gen_random_uuid(), :uid, :d, '08:00', '16:00', 0, 'approved', 'web')"
), {"uid": user_id, "d": three_years_ago})
await db_session.commit()
await db_session.execute(text("SET LOCAL app.bypass_rls = 'on'"))
result = await run_retention_purge(db_session, company_id=company_id)
await db_session.commit()
assert result["time_entries"] >= 1
@@ -92,6 +99,7 @@ async def test_purge_expired_sessions_and_audit_logs_global(
expired = datetime.now(timezone.utc) - timedelta(days=1)
old_audit = datetime.now(timezone.utc) - timedelta(days=4 * 365)
await db_session.execute(text("SET LOCAL app.bypass_rls = 'on'"))
await db_session.execute(text(
"INSERT INTO sessions (id, user_id, refresh_token_hash, expires_at) "
"VALUES (gen_random_uuid(), :uid, :h, :exp)"
@@ -102,6 +110,7 @@ async def test_purge_expired_sessions_and_audit_logs_global(
), {"cid": company_id, "uid": user_id, "ts": old_audit})
await db_session.commit()
await db_session.execute(text("SET LOCAL app.bypass_rls = 'on'"))
result = await run_retention_purge(db_session, company_id=None)
await db_session.commit()
assert result["sessions"] >= 1