Files
rea/src/domain/analysisView/javascriptApplicationView.ts
T
3fca2e0ca6 feat(environment): extract the initial state a capture's reads observed (#5319)
* feat(environment): extract the initial state a capture's reads observed

Add the environment-state analysis view. From the parents the environment
manifest accepts, it extracts the data the capture's reads observed before
the first related write: entity types with an identity field (proved by a
path parameter or inferred from an identity name), entities with their
recorded values and provenance, documents for written non-entity paths, and
a render plan per read tool that is kept only when it reproduces the tool's
latest initial recordings from the state; every other read tool is a
recorded view with the reason. The Evidence is always inferred.

Response-body decoding moves to a domain owner shared with replay, exact
JSON parsing moves to the owner of the exact-number policy, the manifest and
state views share parent admission and record grouping, and
projectAnalysisView takes its accumulators as one object.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* fix(environment): bound state at redacted writes; infer identity only from items

A scenario write whose URL was redacted has no request line, so it was
dropped and reads after it counted as initial state. Such a successful
write now joins the timeline with an empty path, whose root relates to
every type, so it ends every type's state; a limitation counts them.

A list whose recordings were all empty passed the "every listed item
carries it" check vacuously and published an identity field nothing
showed; it now needs at least one item, else the view stays recorded
as no-identity.

A value that differed between two request lines of one item tool, such
as a query variant, was called volatile, and the gate then substituted
each recording's own value; only repeats of one request line now show
volatility, so differing lines go through fields-differ.

List membership is compared only while a list can still be the whole
collection, and merged entities are indexed by type and collection once,
so paged captures no longer cost pages times entities (8,000 pages of
40,000 entities: 5.7 s to 0.23 s).

Docs and the tool contract say scenario state keeps the capture's
redaction markers and how redacted writes bound it.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* fix(environment): keep first sightings, one list pointer and linear field unions

Entities took the order of the first plan observed, and item plans run
before list plans, so a complete list read before its detail reads came
out reordered and lost "all" membership; each entity now keeps its
earliest recorded sighting.

A list plan reused the first recording's pointer for later recordings,
so a later response that was itself an entity wrapping a list was read
as that list; every recording must now locate the same list.

The field union scanned its ordered list for every key, quadratic in an
object's width; a set now answers membership.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* fix(environment): keep post-write values and partial lists out of the initial state

A value that changed between repeats of one request line was named
volatile whenever no write under the type's own root lay between, so a
write under another root (for example POST /api/dashboards/db before a
second GET /api/search) left its effect in the initial state. Any
recorded write between the two observations now leaves every tool of the
type recorded with reason fields-differ instead.

A list was published with membership "all" even when a total or count
envelope member exceeded the number it listed. Such a counter now makes
the membership "recorded".

Also drop a stale doc comment on ObservedEntity.order.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* docs(environment): scope item-shaped and deleted written paths out of documents

State documents are held only for list-shaped paths a POST, PUT or PATCH
tool writes. Reads of item-shaped written paths and of paths that are only
deleted stay recorded views; the guide now says so and the spec defers them
to a later increment of #4933.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* fix(environment): count writes in flight when a value changes between reads

The volatility check compared write start positions with the two reads,
so a write already in flight when the earlier read started was missed and
its effect was named volatile. A write now counts when its interval
overlaps the span from the earlier read's start to the later read's end.

The check also ran once per changed field and scanned every write. It now
runs once per pair of observations, answered by a binary search over the
writes in timeline order and the latest end among each prefix.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* fix(environment): catch cross-tool changes across writes; read only item totals

A value that changed across a write was caught only between repeats of
one tool's request line, so a list read before a write and an item read
after it put the post-write value into the initial state. Changes are
now classified per entity in timeline order after observation: across
any recorded write, a change between repeats of a line or between two
lines of the type rewrites the type (every tool recorded as
fields-differ); with no write between, a repeat's change is volatile.
The classification lives in environmentStateMerge.ts.

Any numeric member whose name contained "total" or "count" counted as
an item total, so total_pages, account_id or page_count made complete
lists partial. Item totals are now members whose name tokens include
total or count and none of page, pages or per; a string of digits counts
as a number; and a set has_more, next or next-page token member also
marks the list partial.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* fix(environment): keep post-write observations out of initial state

* fix(environment): retain field provenance and bound state inference work

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: Kaoru0822 <208281322+kaoru0822-kitauji@users.noreply.github.com>
Co-authored-by: gensokyo-dev <gensokyo-dev@users.noreply.github.com>
2026-10-19 20:33:46 -07:00

429 lines
14 KiB
TypeScript

import {
AnalysisInputError,
type AnalysisInputIssue,
} from "../analysisErrorCore.js";
import type { AnalysisError } from "../analysisErrorBase.js";
import { jsonObjectSchema, type JsonValue } from "../jsonValue.js";
import type { JavaScriptApplicationAnalysisResult } from "../javascript/javascriptApplicationAnalysis.js";
import type { ApplicationNode } from "../javascript/javascriptApplicationGraphSchemas.js";
import { err, ok, type Result } from "../result.js";
import type { JavaScriptModuleReference } from "./javascriptModuleReferences.js";
import {
javascriptApplicationSourceCoverage,
type JavaScriptApplicationSourceCoverage,
} from "./javascriptApplicationCoverage.js";
import { projectJavaScriptFacts } from "./javascriptFactsView.js";
import {
boundedViewMessages,
completeWithinViewCoverage as completeCoverage,
pageViewCoverage as pageCoverage,
} from "./analysisViewCoverage.js";
import type {
AnalysisViewParent,
AnalysisViewRequest,
UnsignedAnalysisView,
} from "./analysisView.js";
const OPERATION = "inspect_analysis_view";
const inputError = (
issues: readonly AnalysisInputIssue[],
): AnalysisInputError => new AnalysisInputError(OPERATION, undefined, issues);
const jsIncompatible = (detail: string): AnalysisError =>
inputError([
{
path: ["view"],
reason: "invalid_value",
message: detail,
},
]);
/** Exact module path or original source-map reference, when available. */
export const javascriptModulePath = (node: ApplicationNode): string | null => {
if (node.identity.strategy === "canonical-path") return node.identity.path;
if (node.identity.strategy === "source-map-original")
return node.identity.original_source;
for (const observation of node.observations) {
const path = observation.properties.path;
if (typeof path === "string") return path;
const location = observation.evidence.location;
if (location.available && location.value.kind === "artifact-path")
return location.value.path;
if (location.available && location.value.kind === "source-range")
return location.value.source;
}
return null;
};
interface ModuleEntry {
readonly node: ApplicationNode & {
readonly kind: JavaScriptModuleReference["kind"];
};
readonly path: string | null;
}
const isModuleNode = (node: ApplicationNode): node is ModuleEntry["node"] =>
node.kind === "javascript-asset" ||
node.kind === "javascript-module" ||
node.kind === "source-module";
/** One owner for the module kinds and path semantics of every module view. */
function* moduleEntries(
nodes: readonly ApplicationNode[],
): Generator<ModuleEntry> {
for (const node of nodes) {
if (isModuleNode(node)) yield { node, path: javascriptModulePath(node) };
}
}
/** Scan retained order once; materialize only the requested matching page. */
const modulePage = (
nodes: readonly ApplicationNode[],
view: {
readonly offset: number;
readonly limit: number;
readonly where?: Extract<
AnalysisViewRequest,
{ kind: "javascript" }
>["where"];
},
): { entries: ModuleEntry[]; total: number } => {
const entries: ModuleEntry[] = [];
let total = 0;
for (const entry of moduleEntries(nodes)) {
if (view.where?.kind !== undefined && entry.node.kind !== view.where.kind)
continue;
if (view.where?.path !== undefined && entry.path !== view.where.path)
continue;
if (total >= view.offset && entries.length < view.limit)
entries.push(entry);
total += 1;
}
return { entries, total };
};
const exportNames = (node: ApplicationNode): readonly string[] => {
const names = new Set<string>();
for (const observation of node.observations) {
const value =
observation.properties.export_names ?? observation.properties.exports;
if (!Array.isArray(value)) continue;
for (const entry of value) if (typeof entry === "string") names.add(entry);
}
return [...names];
};
const nodeHashes = (node: ApplicationNode): readonly string[] => {
const hashes = new Set<string>();
const { identity } = node;
if (identity.strategy === "content-digest") hashes.add(identity.sha256);
if (identity.strategy === "canonical-path")
hashes.add(identity.artifact_sha256);
if (identity.strategy === "source-map-original") {
hashes.add(identity.source_map_sha256);
if (identity.source_sha256 !== null) hashes.add(identity.source_sha256);
}
for (const observation of node.observations) {
for (const key of [
"sha256",
"container_sha256",
"entry_sha256",
"source_sha256",
] as const) {
const value = observation.properties[key];
if (typeof value === "string" && /^[a-f0-9]{64}$/u.test(value))
hashes.add(value);
}
}
return [...hashes];
};
const sourceRanges = (node: ApplicationNode): readonly JsonValue[] =>
node.observations.flatMap((observation) => {
const location = observation.evidence.location;
return location.available && location.value.kind === "source-range"
? [location.value]
: [];
});
const moduleItem = (node: ApplicationNode): JsonValue => ({
node_id: node.node_id,
kind: node.kind,
path: javascriptModulePath(node),
identity: node.identity,
hashes: [...nodeHashes(node)],
exports: [...exportNames(node)],
source_ranges: [...sourceRanges(node)],
observations: node.observations.map((observation) => ({
observation_id: observation.observation_id,
label: observation.label,
properties: observation.properties,
evidence: {
...observation.evidence,
location: observation.evidence.location,
},
})),
});
const moduleReference = ({
node,
path,
}: ModuleEntry): JavaScriptModuleReference => {
let ranges = 0;
const support = new Map<string, JavaScriptModuleReference["basis"][number]>();
for (const { evidence } of node.observations) {
if (
evidence.location.available &&
evidence.location.value.kind === "source-range"
)
ranges += 1;
const { authority, state, confidence } = evidence;
support.set(`${authority}:${state}:${confidence}`, {
authority,
state,
confidence,
});
}
return {
node_id: node.node_id,
kind: node.kind,
path,
identity: node.identity,
retained_source_range_count: ranges,
basis: [...support.values()],
};
};
const javascriptCoverageUnknowns = (
coverage: JavaScriptApplicationSourceCoverage,
): readonly string[] => {
const unknowns: string[] = [];
if (coverage.application.status !== "complete")
unknowns.push(`graph.coverage.status is ${coverage.application.status}`);
if (coverage.semantic.status !== "complete")
unknowns.push(
`semantic_graph.coverage.status is ${coverage.semantic.status}`,
);
const applicationUnknowns = coverage.application_unknown_count;
if (applicationUnknowns > 0)
unknowns.push(
`${String(applicationUnknowns)} application graph unknowns remain in the parent Evidence.`,
);
if (coverage.semantic_unknown_count > 0)
unknowns.push(
`${String(coverage.semantic_unknown_count)} semantic graph unknowns remain in the parent Evidence.`,
);
return unknowns;
};
const parentFields = (
parent: AnalysisViewParent,
analysis: JavaScriptApplicationAnalysisResult,
sourceCoverage: JavaScriptApplicationSourceCoverage,
) => {
const limitations = [
...analysis.limitations,
...analysis.graph.limitations,
...analysis.semantic_graph.limitations,
];
return {
parent_evidence_id: parent.evidenceId,
parent_operation: "analyze_javascript_application" as const,
parent_digest: parent.evidenceId.slice(3),
artifact: {
path: analysis.input_path,
sha256: analysis.root_artifact_sha256,
},
limitations: boundedViewMessages(
[...parent.limitations, ...limitations],
parent.evidenceId,
"limitations",
),
unknowns: boundedViewMessages(
limitations,
parent.evidenceId,
"unknowns",
javascriptCoverageUnknowns(sourceCoverage),
),
};
};
const selectModule = (
modules: readonly ModuleEntry[],
selector: Extract<AnalysisViewRequest, { readonly kind: "item" }>["selector"],
): Result<ApplicationNode, AnalysisError> => {
if ("node_id" in selector) {
const matches = modules.filter(
({ node }) => node.node_id === selector.node_id,
);
if (matches.length === 1) {
const selected = matches[0];
if (selected !== undefined) return ok(selected.node);
}
return err(
inputError([
{
path: ["view", "selector", "node_id"],
reason: "invalid_value",
message: `No module has node_id ${JSON.stringify(selector.node_id)}. Page the modules collection to inspect available identities.`,
},
]),
);
}
if ("path" in selector) {
const matches = modules.filter((entry) => entry.path === selector.path);
if (matches.length === 1) {
const selected = matches[0];
if (selected !== undefined) return ok(selected.node);
}
if (matches.length === 0)
return err(
inputError([
{
path: ["view", "selector", "path"],
reason: "invalid_value",
message: `No module has path ${JSON.stringify(selector.path)}. Page the modules collection to inspect exact paths and node_id values.`,
},
]),
);
return err(
inputError([
{
path: ["view", "selector", "path"],
reason: "invalid_value",
message: `Multiple modules have path ${JSON.stringify(selector.path)}; select one by node_id.`,
expected: matches.map((entry) => ({ node_id: entry.node.node_id })),
},
]),
);
}
return err(
jsIncompatible("Module items are selected by exact path or node_id."),
);
};
/** Project one JavaScript application view without re-running reconstruction. */
export const projectJavaScriptApplicationView = (
parent: AnalysisViewParent,
analysis: JavaScriptApplicationAnalysisResult,
view: Exclude<
AnalysisViewRequest,
{ kind: "api-surface" | "environment-manifest" | "environment-state" }
>,
): Result<UnsignedAnalysisView, AnalysisError> => {
if (
view.kind !== "summary" &&
view.kind !== "item" &&
view.kind !== "page" &&
view.kind !== "javascript" &&
view.kind !== "javascript-facts"
)
return err(
jsIncompatible(
"JavaScript application Evidence supports summary, module item/page, typed module references or selected JavaScript facts.",
),
);
const sourceCoverage = javascriptApplicationSourceCoverage(analysis);
const shared = parentFields(parent, analysis, sourceCoverage);
if (view.kind === "javascript-facts") {
const { rows, total } = projectJavaScriptFacts(analysis.graph.nodes, view);
return ok({
...shared,
kind: "javascript-facts",
view,
rows,
source_coverage: sourceCoverage,
coverage: pageCoverage(view.offset, rows.length, total),
});
}
if (view.kind === "javascript") {
const { entries, total } = modulePage(analysis.graph.nodes, view);
const rows = entries.map(moduleReference);
return ok({
...shared,
kind: "javascript",
view,
rows,
source_coverage: sourceCoverage,
coverage: pageCoverage(view.offset, rows.length, total),
});
}
if (view.kind === "summary") {
const moduleCount = analysis.graph.nodes.reduce(
(count, node) => count + Number(isModuleNode(node)),
0,
);
return ok({
kind: "summary",
view,
summary: {
input_path: analysis.input_path,
format: analysis.format,
root_artifact_sha256: analysis.root_artifact_sha256,
...(analysis.source_selection === undefined
? {}
: {
source_selection: analysis.source_selection,
}),
statistics: jsonObjectSchema.parse(analysis.statistics),
electron: jsonObjectSchema.parse(analysis.summary),
coverage: jsonObjectSchema.parse({
application: analysis.graph.coverage,
semantic: {
...analysis.semantic_graph.coverage,
families: analysis.semantic_graph.coverage.families.map(
({ unknown_ids, ...family }) => ({
...family,
unknown_count: unknown_ids.length,
}),
),
},
application_unknowns: sourceCoverage.application_unknown_count,
semantic_unknowns: sourceCoverage.semantic_unknown_count,
}),
limitation_count: analysis.limitations.length,
},
coverage: completeCoverage(moduleCount, analysis.graph.nodes.length),
...shared,
});
}
if (view.kind === "item") {
if (view.collection !== "modules")
return err(
jsIncompatible(
"Section and symbol collections apply to inspect_binary_layout Evidence.",
),
);
const modules = [...moduleEntries(analysis.graph.nodes)];
const selected = selectModule(modules, view.selector);
if (!selected.ok) return selected;
return ok({
kind: "item",
view,
item: moduleItem(selected.value),
coverage: completeCoverage(1, modules.length),
...shared,
});
}
if (view.kind !== "page" || view.collection !== "modules")
return err(
jsIncompatible(
"Section and symbol collections apply to inspect_binary_layout Evidence.",
),
);
const { entries, total } = modulePage(analysis.graph.nodes, view);
const items = entries.map(({ node, path }) => ({
node_id: node.node_id,
kind: node.kind,
path,
}));
return ok({
kind: "page",
view,
items,
coverage: pageCoverage(view.offset, items.length, total),
...shared,
});
};