morluto
ffe0574e17
Keep failed reader, root descriptor, and output-tree cleanup with the caller. Drain admitted work before close, retry the same retained owners, and block new resource work while cleanup is incomplete. Preserve primary failures and complete inventory observations. Thread ownership through JavaScript reconstruction, the CLI's one-shot scope, MCP server shutdown, verifier scripts, and test fixtures. Remove redundant ownership flags and the unused validated test wrapper. Validate with 850 passing focused tests across 90 suites (two skipped), targeted classification and cleanup retries, static and unused-code checks, and real macOS CLI/MCP directory, ZIP, and DMG workflows. Native Windows and deep-analysis providers were not verified. BREAKING CHANGE: Direct artifact inventory/extraction and JavaScript analysis APIs require an explicit caller-owned ArtifactResourceScope. CLI and MCP input contracts are unchanged.
55 lines
1.9 KiB
TypeScript
55 lines
1.9 KiB
TypeScript
import { execFile } from "node:child_process";
|
|
import { lstat, rename, rm, writeFile } from "node:fs/promises";
|
|
import { join } from "node:path";
|
|
import { promisify } from "node:util";
|
|
|
|
import { expect, it } from "vitest";
|
|
|
|
import {
|
|
classifyAndHashRoot,
|
|
inventoryArtifact,
|
|
} from "../../fixtures/artifactInventory.js";
|
|
import { createTestTempDirectory } from "../../fixtures/temporaryDirectory.js";
|
|
import { readWithoutFifoWriter } from "../../fixtures/fifoInput.js";
|
|
|
|
it.skipIf(process.platform === "win32")(
|
|
"rejects a FIFO artifact root without waiting for a writer",
|
|
async () => {
|
|
const root = await createTestTempDirectory("rea-artifact-root-fifo-");
|
|
const fifoPath = join(root, "input.asar");
|
|
await promisify(execFile)("mkfifo", [fifoPath]);
|
|
|
|
const outcome = await readWithoutFifoWriter(fifoPath, () =>
|
|
inventoryArtifact(fifoPath).then(
|
|
() => undefined,
|
|
(cause: unknown) => cause,
|
|
),
|
|
);
|
|
expect(outcome.state).toBe("completed");
|
|
if (outcome.state !== "completed")
|
|
throw new Error("Artifact inventory waited for a FIFO writer");
|
|
expect(outcome.result).toMatchObject({
|
|
reason: "format",
|
|
message: `Artifact root is not a regular file: ${fifoPath}`,
|
|
});
|
|
},
|
|
);
|
|
|
|
it("rejects a root path replaced between its initial stat and open", async () => {
|
|
const root = await createTestTempDirectory("rea-artifact-root-replaced-");
|
|
const path = join(root, "input.bin");
|
|
const replacement = join(root, "replacement.bin");
|
|
await writeFile(path, "first bytes\n");
|
|
const expectedMetadata = await lstat(path);
|
|
await writeFile(replacement, "different bytes\n");
|
|
await rm(path);
|
|
await rename(replacement, path);
|
|
|
|
await expect(
|
|
classifyAndHashRoot(path, false, expectedMetadata),
|
|
).rejects.toMatchObject({
|
|
reason: "integrity",
|
|
message: `Root artifact changed before inventory: ${path}`,
|
|
});
|
|
});
|